[PATCH 2/3] dt-bindings: drm/panel: simple: add Evervision VGG804821

Sam Ravnborg sam at ravnborg.org
Fri Jan 11 17:17:00 UTC 2019


Hi Rob.

> > > +++ b/Documentation/devicetree/bindings/display/panel/evervision,vgg804821.txt
> > > @@ -0,0 +1,12 @@
> > > +Evervision Electronics Co. Ltd. VGG804821 5.0" WVGA TFT LCD Panel
> > > +
> > > +Required properties:
> > > +- compatible: should be "evervision,vgg804821"
> > > +- power-supply: See simple-panel.txt
> > > +
> > > +Optional properties:
> > > +- backlight: See simple-panel.txt
> > > +- enable-gpios: See simple-panel.txt
> > > +
> > > +This binding is compatible with the simple-panel binding, which is specified
> > > +in simple-panel.txt in this directory.
> > 
> > Other bindings just have the compatible listed and the above two lines and
> > do not repeat the required/optional properties.
> > If there is not special reason to add these they I suggest to simplify the binding.
> 
> It is not sufficient to just refer to simple-panel.txt. For example, 
> that doesn't convey if a panel has a single supply or multiple and the 
> author just ignored supplies. Or what if a panel doesn't have a 
> backlight or enable line?

Thanks, noted.
I have a few bindings awaiting to be sent that will need a small update.

	Sam


More information about the dri-devel mailing list