[PATCH 3/4] drm/rockchip: add missing of_node_put
Heiko Stuebner
heiko at sntech.de
Sun Jan 13 18:48:49 UTC 2019
Am Sonntag, 13. Januar 2019, 09:47:43 CET schrieb Julia Lawall:
> The device node iterators perform an of_node_get on each iteration, so a
> jump out of the loop requires an of_node_put.
>
> The semantic patch that fixes this problem is as follows
> (http://coccinelle.lip6.fr):
>
> // <smpl>
> @@
> expression root,e;
> local idexpression child;
> iterator name for_each_child_of_node;
> @@
>
> for_each_child_of_node(root, child) {
> ... when != of_node_put(child)
> when != e = child
> + of_node_put(child);
> ? break;
> ...
> }
> ... when != child
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall at lip6.fr>
I've added a fixes+stable tag and applied it to drm-misc-fixes
Thanks for catching that
Heiko
More information about the dri-devel
mailing list