[PATCH] drm/crtc-helper: Add store the property value

Daniel Vetter daniel at ffwll.ch
Thu Jan 17 09:20:15 UTC 2019


On Thu, Jan 17, 2019 at 05:50:44PM +0900, Hoegeun Kwon wrote:
> There is a problem in crtc_helper that property value is not updated
> when dpms is turned on or off. So modify the property value when dpms
> is on.
> 
> Signed-off-by: Hoegeun Kwon <hoegeun.kwon at samsung.com>

This is fixed with atomic, and exynos is atomic. Why do you care about
this?
-Daniel

> ---
>  drivers/gpu/drm/drm_crtc_helper.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c
> index a3c81850e755..57d359f0725c 100644
> --- a/drivers/gpu/drm/drm_crtc_helper.c
> +++ b/drivers/gpu/drm/drm_crtc_helper.c
> @@ -735,6 +735,10 @@ int drm_crtc_helper_set_config(struct drm_mode_set *set,
>  				DRM_DEBUG_KMS("\t[CONNECTOR:%d:%s] set DPMS on\n", set->connectors[i]->base.id,
>  					      set->connectors[i]->name);
>  				set->connectors[i]->funcs->dpms(set->connectors[i], DRM_MODE_DPMS_ON);
> +
> +				drm_object_property_set_value(&set->connectors[i]->base,
> +							set->connectors[i]->dev->mode_config.dpms_property,
> +							DRM_MODE_DPMS_ON);
>  			}
>  		}
>  		__drm_helper_disable_unused_functions(dev);
> -- 
> 2.17.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the dri-devel mailing list