[v2,2/3] drm/vkms: Add basic CRTC initialization

Rodrigo Siqueira rodrigosiqueiramelo at gmail.com
Mon Jan 21 08:57:03 UTC 2019


On 01/18, Thomas Gleixner wrote:
> Rodrigo,
> 
> On Wed, 16 May 2018, Rodrigo Siqueira wrote:
> 
> All files added by this commit have inconsistent license information:
> 
> > --- /dev/null
> > +++ b/drivers/gpu/drm/vkms/vkms_crtc.c
> > @@ -0,0 +1,35 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License as published by
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> > + */
> 
> > --- /dev/null
> > +++ b/drivers/gpu/drm/vkms/vkms_output.c
> > @@ -0,0 +1,91 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License as published by
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> > + */
> 
> > --- /dev/null
> > +++ b/drivers/gpu/drm/vkms/vkms_plane.c
> > @@ -0,0 +1,46 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License as published by
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> > + */
> 
> The SPDX license identifier says GPL v2 only, but the license notice says
> GPL v2 or later. This is just wrong.
> 
> Please decide which one to use and please also remove the boiler plate
> text. It is redundant.
> 
> See Documentation/process/license-rules.rst
> 
> Please fix ASAP, add a Fixes tag and cc stable.

Hi Thomas,

Thanks for your feedback. I'll try to send a patch for fix this issue
today.

Best Regards
Rodrigo Siqueira
 
> Thanks,
> 
>         tglx

-- 
Rodrigo Siqueira
https://siqueira.tech
Graduate Student
Department of Computer Science
University of São Paulo


More information about the dri-devel mailing list