[PATCH] drm/fb-helper: generic: Fix drm_fbdev_client_restore()

Gerd Hoffmann kraxel at redhat.com
Mon Jan 28 06:48:18 UTC 2019


> Fix by using drm_fb_helper_lastclose() which checks if fbdev is in use.

>  static int drm_fbdev_client_restore(struct drm_client_dev *client)
>  {
> -	struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client);
> -
> -	drm_fb_helper_restore_fbdev_mode_unlocked(fb_helper);
> +	drm_fb_helper_lastclose(client->dev);
>  
>  	return 0;
>  }

Hmm, at least the drm_fb_helper_lastclose() version I'm looking at
(branch drm-misc-next) just calls
drm_fb_helper_restore_fbdev_mode_unlocked without any check ...

cheers,
  Gerd



More information about the dri-devel mailing list