[PATCH] drm/doc: Make igts for cross-driver stuff strongly suggested

[Jani Nikula]

On Mon, 28 Jan 2019, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> Compared to the RFC[1] no changes to the patch itself, but igt moved
> forward a lot:

This is no longer compatible with the v2 changelog below. ;)

I'm biased so this doesn't carry so much value, but here goes anyway,

Acked-by: Jani Nikula <jani.nikula at intel.com>

>
> - gitlab CI builds with: reduced configs/libraries, arm cross build
>   and a sysroot build (should address all the build/cross platform
>   concerns raised in the RFC discussions).
>
> - tests reorganized into subdirectories so that the i915-gem tests
>   don't clog the main/shared tests directory anymore
>
> - quite a few more non-intel people contributing/reviewing/committing
>   igt tests patches.
>
> I think this addresses all the concerns raised in the RFC discussions,
> and assuming there's enough Acks and no new issues that pop up, we can
> go ahead with this.
>
> v2:
> - Use "should" (in the usual RFC sense) to make it clear that in the
>   end this is all up to reviewer's discretion, as usual (Jani).
> - Also in the title s/mandatory/strongly suggested/ (me)
> - Make it clear we're not going to block features if a testcase is not
>   feasible, given hw and state of igt, both having some good gaps in
>   what can be tested (Harry, Eric, Sean, ...).
>
> 1: https://patchwork.kernel.org/patch/10648851/
> Cc: Petri Latvala <petri.latvala at intel.com>
> Cc: Arkadiusz Hiler <arkadiusz.hiler at intel.com>
> Cc: Liviu Dudau <liviu.dudau at arm.com>
> Cc: Sean Paul <sean at poorly.run>
> Cc: Eric Anholt <eric at anholt.net>
> Cc: Alex Deucher <alexander.deucher at amd.com>
> Cc: Dave Airlie <airlied at redhat.com>
> Cc: Daniel Stone <daniel at fooishbar.org>
> Cc: "Wentland, Harry" <Harry.Wentland at amd.com>
> Cc: Brian Starkey <Brian.Starkey at arm.com>
> Reviewed-by: Eric Anholt <eric at anholt.net> (v1)
> Acked-by: Petri Latvala <petri.latvala at intel.com>
> Acked-by: Arkadiusz Hiler <arkadiusz.hiler at intel.com>
> Acked-by: Sean Paul <sean at poorly.run>
> Acked-by: "Wentland, Harry" <Harry.Wentland at amd.com>
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> ---
>  Documentation/gpu/drm-uapi.rst | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/gpu/drm-uapi.rst b/Documentation/gpu/drm-uapi.rst
> index a752aa561ea4..c9fd23efd957 100644
> --- a/Documentation/gpu/drm-uapi.rst
> +++ b/Documentation/gpu/drm-uapi.rst
> @@ -238,6 +238,14 @@ DRM specific patterns. Note that ENOTTY has the slightly unintuitive meaning of
>  Testing and validation
>  ======================
>  
> +Testing Requirements for userspace API
> +--------------------------------------
> +
> +New cross-driver userspace interface extensions, like new IOCTL, new KMS
> +properties, new files in sysfs or anything else that constitutes an API change
> +should have driver-agnostic testcases in IGT for that feature, if such a test
> +can be reasonably made using IGT for the target hardware.
> +
>  Validating changes with IGT
>  ---------------------------

-- 
Jani Nikula, Intel Open Source Graphics Center