[PATCH 1/2] drm/imx: imx-tve: depend on COMMON_CLK

[Linus Walleij]

On Wed, Jan 30, 2019 at 10:01 AM Philipp Zabel <p.zabel at pengutronix.de> wrote:
> On Wed, 2019-01-30 at 09:16 +0100, Linus Walleij wrote:
> > On Thu, Jan 24, 2019 at 1:51 PM Philipp Zabel <p.zabel at pengutronix.de> wrote:
> >
> > > Since the TVE provides a clock to the DI, the driver can only be
> > > compiled if the common clock framework is enabled. With the COMMON_CLK
> > > dependency in place, it will be possible to allow building the other
> > > parts of imx-drm under COMPILE_TEST on architectures that do not select
> > > the common clock framework.
> > >
> > > Signed-off-by: Philipp Zabel <p.zabel at pengutronix.de>
> >
> > Since the clock framework has stubs I bet it can be *compiled* without
> > COMMON_CLK. But it will certainly not work so if you reword the commit:
> > Reviewed-by: Linus Walleij <linus.walleij at linaro.org>
>
> thank you for the review. It indeed does not compile because struct
> imx_tve embeds a struct clk_hw, which is defined in linux/clk-provider.h
> only if COMMON_CLK is enabled.

Oh that one, I see it is a clock driver.
Sorry for my ignorance.
Reviewed-by: Linus Walleij <linus.walleij at linaro.org>

Yours,
Linus Walleij