[PATCH] drm: bridge: DRM_SIL_SII8620 should depend on, not select INPUT

[Andrzej Hajda]

On 01.07.2019 05:39, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap at infradead.org>
>
> A single driver should not enable (select) an entire subsystem,
> such as INPUT, so change the 'select' to "depends on".
>
> Fixes: d6abe6df706c ("drm/bridge: sil_sii8620: do not have a dependency of RC_CORE")
>
> Signed-off-by: Randy Dunlap <rdunlap at infradead.org>
> Cc: Inki Dae <inki.dae at samsung.com>
> Cc: Andrzej Hajda <a.hajda at samsung.com>
> Cc: Laurent Pinchart <Laurent.pinchart at ideasonboard.com>
> Cc: dri-devel at lists.freedesktop.org
> ---
> Linus has written this a couple of times in the last 15 years or so,
> but my search fu cannot find it.  And there are a few drivers in the
> kernel tree that do this, but we shouldn't be adding more that do so.


The proper solution has been already posted [1], but it has not been
applied yet to input tree?

Randy are there chances your patchset will appear in ML in near future,
or should I merge your sii8620 patch alone?


[1]:
https://lore.kernel.org/lkml/20190419081926.13567-2-ronald@innovation.ch/


Regards

Andrzej



>
>  drivers/gpu/drm/bridge/Kconfig |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> --- lnx-52-rc7.orig/drivers/gpu/drm/bridge/Kconfig
> +++ lnx-52-rc7/drivers/gpu/drm/bridge/Kconfig
> @@ -83,10 +83,9 @@ config DRM_PARADE_PS8622
>  
>  config DRM_SIL_SII8620
>  	tristate "Silicon Image SII8620 HDMI/MHL bridge"
> -	depends on OF
> +	depends on OF && INPUT
>  	select DRM_KMS_HELPER
>  	imply EXTCON
> -	select INPUT
>  	select RC_CORE
>  	help
>  	  Silicon Image SII8620 HDMI/MHL bridge chip driver.
>
>
>
>