[PATCH v2 5/5] drm/vram: Don't export driver callback functions for PRIME

Gerd Hoffmann kraxel at redhat.com
Tue Jul 2 10:53:40 UTC 2019


> > > -/**
> > > - * drm_gem_vram_driver_gem_free_object_unlocked() - \
> > > -     Implements &struct drm_driver.gem_free_object_unlocked
> > > - * @gem:     GEM object. Refers to &struct drm_gem_vram_object.gem
> > > - */
> >
> > I think we should keep the documentation ...
> >
> > > -EXPORT_SYMBOL(drm_gem_vram_driver_gem_free_object_unlocked);
> >
> > And the EXPORT_SYMBOL too.
> >
> > Drivers might want roll their own version of drm_gem_object_funcs,
> > with some of the functions replaced by driver-specific versions in
> > case they have some extra work to do.
> >
> Keeping the comment sounds reasonable IMHO. Although I'm less sure
> about EXPORT_SYMBOL.
> If you have WIP series that makes use of it, sure. Otherwise any
> driver wants to use it, they can trivially reinstate that.

No pending patches.  It's common practice in the other helpers though.
But I don't mind much either way, adding back the EXPORT_SYMBOL() if
needed is easy enough.

cheers,
  Gerd



More information about the dri-devel mailing list