[PATCH 02/60] video: hdmi: Change return type of hdmi_avi_infoframe_init() to void

[Ilia Mirkin]

On Sun, Jul 7, 2019 at 2:15 PM Laurent Pinchart
<laurent.pinchart at ideasonboard.com> wrote:
>
> Sorry, forgot to CC Bartlomiej on this patch.
>
> On Sun, Jul 07, 2019 at 09:07:54PM +0300, Laurent Pinchart wrote:
> > The hdmi_avi_infoframe_init() never needs to return an error, change its
> > return type to void.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> > ---
> >  drivers/gpu/drm/drm_edid.c | 5 +----
> >  drivers/video/hdmi.c       | 9 ++-------
> >  include/linux/hdmi.h       | 2 +-
> >  3 files changed, 4 insertions(+), 12 deletions(-)
> >
> > diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c
> > index b939bc28d886..54fb7cf11d1a 100644
> > --- a/drivers/video/hdmi.c
> > +++ b/drivers/video/hdmi.c
> > @@ -56,15 +56,13 @@ static void hdmi_infoframe_set_checksum(void *buffer, size_t size)
> >   *
> >   * Returns 0 on success or a negative error code on failure.

Probably want to adjust this text too, then?

[I have no opinion on whether this patch is good or bad, just happened
to notice the inconsistency.]

Cheers,

  -ilia

> >   */
> > -int hdmi_avi_infoframe_init(struct hdmi_avi_infoframe *frame)
> > +void hdmi_avi_infoframe_init(struct hdmi_avi_infoframe *frame)
> >  {
> >       memset(frame, 0, sizeof(*frame));
> >
> >       frame->type = HDMI_INFOFRAME_TYPE_AVI;
> >       frame->version = 2;
> >       frame->length = HDMI_AVI_INFOFRAME_SIZE;
> > -
> > -     return 0;
> >  }
> >  EXPORT_SYMBOL(hdmi_avi_infoframe_init);
> >