[PATCH 4/5] drm/syncobj: Include the prototype for drm_timeout_abs_to_jiffies()

Sean Paul sean at poorly.run
Thu Jul 11 15:39:15 UTC 2019


On Wed, Jul 10, 2019 at 03:51:42PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Sparse complains:
> ../drivers/gpu/drm/drm_syncobj.c:942:13: warning: symbol 'drm_timeout_abs_to_jiffies' was not declared. Should it be static?
> 
> Include the correct header with the prototype.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
>  drivers/gpu/drm/drm_syncobj.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c
> index a199c8d56b95..00eecc9c464b 100644
> --- a/drivers/gpu/drm/drm_syncobj.c
> +++ b/drivers/gpu/drm/drm_syncobj.c
> @@ -58,6 +58,7 @@
>  #include <drm/drm_gem.h>
>  #include <drm/drm_print.h>
>  #include <drm/drm_syncobj.h>
> +#include <drm/drm_utils.h>

Just realized we have both drm_util.h and drm_utils.h, what a world!

Reviewed-by: Sean Paul <sean at poorly.run>

>  
>  #include "drm_internal.h"
>  
> -- 
> 2.21.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Sean Paul, Software Engineer, Google / Chromium OS


More information about the dri-devel mailing list