[PATCH 2/2] Staging: fbtft: Fix reset assertion when using gpio descriptor

Jan Sebastian Götte linux at jaseg.net
Mon Jul 15 14:40:37 UTC 2019


I have tested these changes on an ili9486-based display connected through SPI to a raspberry pi and can confirm they work in combination with another patch I'll send shortly. I only had to fix the reset pin polarity in the device tree overlay I used.

Regards, Jan

On July 11, 2019, 8:31 a.m., Phil Reid wrote:
> Typically gpiod_set_value calls would assert the reset line and
> then release it using the symantics of:
> 	gpiod_set_value(par->gpio.reset, 0);
> 	... delay
> 	gpiod_set_value(par->gpio.reset, 1);
> And the gpio binding would specify the polarity.
> 
> Prior to conversion to gpiod calls the polarity in the DT
> was ignored and assumed to be active low. Fix it so that
> DT polarity is respected.
> 
> Signed-off-by: Phil Reid <preid at electromag.com.au>
> ---
>  drivers/staging/fbtft/fbtft-core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Tested-by: Jan Sebastian Götte <linux at jaseg.net>


More information about the dri-devel mailing list