[Intel-gfx] [PATCH v3 1/3] drm/gem: don't force writecombine mmap'ing

Eric Anholt eric at anholt.net
Tue Jul 16 23:21:01 UTC 2019


Rob Clark <robdclark at gmail.com> writes:

> From: Rob Clark <robdclark at chromium.org>
>
> The driver should be in control of this.
>
> Signed-off-by: Rob Clark <robdclark at chromium.org>
> ---
> It is possible that this was masking bugs (ie. not setting appropriate
> pgprot) in drivers.  I don't have a particularly good idea for tracking
> those down (since I don't have the hw for most drivers).  Unless someone
> has a better idea, maybe land this and let driver maintainers fix any
> potential fallout in their drivers?
>
> This is necessary for the last patch to fix VGEM brokenness on arm.

This will break at least v3d and panfrost, and it looks like cirrus as
well, since you're now promoting the mapping to cached by default and
drm_gem_shmem_helper now produces cached mappings.  That's all I could
find that would break, but don't trust me on that.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20190716/effee2b9/attachment.sig>


More information about the dri-devel mailing list