[PATCH 05/10] drm/tinydrm: Clean up tinydrm_spi_transfer()

Sam Ravnborg sam at ravnborg.org
Wed Jul 17 13:09:09 UTC 2019


On Wed, Jul 17, 2019 at 01:58:12PM +0200, Noralf Trønnes wrote:
> Prep work before moving the function to mipi-dbi.
> 
> tinydrm_spi_transfer() was made to support one class of drivers in
> drivers/staging/fbtft that has not been converted to DRM yet, so strip
> away the unused functionality:
> - Start byte (header) is not used.
> - No driver relies on the automatic 16-bit byte swapping on little endian
>   machines with SPI controllers only supporting 8 bits per word.

Keeping unused code around is never a good idea.
On the other hand, should we not try to get the driver in questions
ported so we have a user and we do not need to re-add this later?
What driver/display needs this?

	Sam


More information about the dri-devel mailing list