[PATCH 06/10] drm/tinydrm: Move tinydrm_spi_transfer()

David Lechner david at lechnology.com
Wed Jul 17 19:48:11 UTC 2019


On 7/17/19 6:58 AM, Noralf Trønnes wrote:
> This is only used by mipi-dbi drivers so move it there.
> 
> The reason this isn't moved to the SPI subsystem is that it will in a
> later patch pass a dummy rx buffer for SPI controllers that need this.
> Low memory boards (64MB) can run into a problem allocating such a "large"
> contiguous buffer on every transfer after a long up time.
> This leaves a very specific use case, so we'll keep the function here.
> mipi-dbi will first go through a refactoring though, before this will
> be done.
> 
> Remove SPI todo entry now that we're done with the tinydrm.ko SPI code.
> 
> Additionally move the mipi_dbi_spi_init() declaration to the other SPI
> functions.
> 
> Cc: David Lechner <david at lechnology.com>
> Signed-off-by: Noralf Trønnes <noralf at tronnes.org>
> ---

Acked-by: : David Lechner <david at lechnology.com>

I assume that the comments here might have something to do with the
issue[1] I raised a while back? Should I dust that patch off and resend
it after this series lands?

[1]: https://lore.kernel.org/lkml/1519082461-32405-1-git-send-email-david@lechnology.com/


More information about the dri-devel mailing list