[PATCH v2 2/4] drm/via: add VIA_WAIT_ON()

Emil Velikov emil.l.velikov at gmail.com
Mon Jul 22 15:46:08 UTC 2019


On Sat, 20 Jul 2019 at 09:46, Sam Ravnborg <sam at ravnborg.org> wrote:
>
> VIA_WAIT_ON() is a direct copy of DRM_WAIT_ON() from
> drm_os_linux.h.
> The copy is made so we can avoid the dependency on the legacy header.
> A more involved approach had been to introduce wait_event_* but for this
> legacy driver the simpler and more safe approach with a copy of the
> macro was selected.
> Added the relevant header files for the functions used in VIA_WAIT_ON.
>
> Users of the macro will come in a follow-up patch.
>
Since nothing "new" is added here I would change the summary to
"drm/via: copy DRM_WAIT_ON as VIA_WAIT_ON and use it"
IMHO there's little point in splitting introduction and usage.

-Emil


More information about the dri-devel mailing list