[PATCH 0/6] drm/tinydrm: Move mipi_dbi

[Noralf Trønnes]

Den 23.07.2019 09.10, skrev Daniel Vetter:
> On Mon, Jul 22, 2019 at 11:06:15AM -0700, Eric Anholt wrote:
>> Noralf Trønnes <noralf at tronnes.org> writes:
>>
>>> This series ticks off the last tinydrm todo entry and moves out mipi_dbi
>>> to be a core helper.
>>>
>>> It splits struct mipi_dbi into an interface part and a display pipeline
>>> part (upload framebuffer over SPI). I also took the opportunity to
>>> rename the ambiguous 'mipi' variable name to 'dbi'. This lines up with
>>> the use of the 'dsi' variable name in the MIPI DSI helper.
>>>
>>> Note:
>>> This depends on series: drm/tinydrm: Remove tinydrm.ko
>>>
>>> Series is also available here:
>>> https://github.com/notro/linux/tree/move_mipi_dbi
>>
>> Congratulations on making it to this stage.  This looks like a fine
>> conclusion to tinydrm.
>>
>> Acked-by: Eric Anholt <eric at anholt.net>
> 
> Yeah let me heap on the congrats too, this has ben a long but really
> impressive journey to watch!

Looking back it's suprising to me that I continued to work on this.
After Linus took a dump on tinydrm I wasn't much interested in doing any
further work on Linux, there are lots of other interesting projects to
work on. Then you cc'ed me on a patch telling me that someone was using
the simple display helper I made, and before I knew it I was knee deep
in refactoring work.

One big take away for me has been how much better my code becomes after
going through a review process. Some times, looking back, I wonder - did
I actually write that nice piece of code? And the real answer I guess is
that I did the typing and often had the idea, but many times the fleshed
out solution was not something that I came up with.

Noralf.

> -Daniel
>