[PATCH] drm: Add Grain Media GM12U320 driver v2

Noralf Trønnes noralf at tronnes.org
Tue Jul 23 15:34:53 UTC 2019



Den 23.07.2019 09.33, skrev Daniel Vetter:
> On Sun, Jul 21, 2019 at 03:25:25PM +0200, Hans de Goede wrote:
>> Add a modesetting driver for Grain Media GM12U320 based devices
>> (primarily Acer C120 projector, but there may be compatible devices).
>>
>> This is based on the fb driver from Viacheslav Nurmekhamitov:
>> https://github.com/slavrn/gm12u320
>>
>> This driver uses drm_simple_display_pipe to deal with all the atomic
>> stuff, gem_shmem_helper functions for buffer management and
>> drm_fbdev_generic_setup for fbdev emulation, so that leaves the driver
>> itself with only the actual code for talking to the gm13u320 chip,
>> leading to a nice simple and clean driver.
>>
>> Changes in v2:
>> -Add drm-misc tree to MAINTAINERS
>> -Drop mode_config.preferred_depth = 24 / fix fbdev support
>>
>> Reviewed-by: Noralf Trønnes <noralf at tronnes.org>
>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
>> ---
>>  MAINTAINERS                         |   6 +
>>  drivers/gpu/drm/Kconfig             |   2 +
>>  drivers/gpu/drm/Makefile            |   1 +
>>  drivers/gpu/drm/gm12u320/Kconfig    |   9 +
>>  drivers/gpu/drm/gm12u320/Makefile   |   2 +
>>  drivers/gpu/drm/gm12u320/gm12u320.c | 815 ++++++++++++++++++++++++++++
> 
> Hm I thought Noralf's plan was to collect all such tiny drivers into
> drm/tinydrm (or drm/tiny). I kinda like that idea, instead of litering the
> top level with tons of directories and forcing everyone to create a new
> Makefile/Kconfig.
> 

That has been my long term plan, but I didn't know when I would get to
that point. There's always somethings that come up and I didn't know if
I would get the necessary reviews now that many are on summer vacation.
I have now gotten the necessary ack/r-b to move on and I found a
solution to the BACKLIGHT dependency problem I had, so this has
progressed faster than I could hope for.

> Maybe we could move this as part of the tinydrm->tiny/ rename?

I can add a patch that does that.

Noralf.

> -Daniel
> 


More information about the dri-devel mailing list