[PATCH -next] drm/mga: remove set but not used variable 'buf_priv'
Thomas Zimmermann
tzimmermann at suse.de
Wed Jul 24 07:40:25 UTC 2019
Am 24.07.19 um 03:46 schrieb YueHaibing:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/mga/mga_state.c: In function 'mga_dma_iload':
> drivers/gpu/drm/mga/mga_state.c:945:22: warning:
> variable 'buf_priv' set but not used [-Wunused-but-set-variable]
>
> It is never used, so can be removed.
>
> Reported-by: Hulk Robot <hulkci at huawei.com>
> Signed-off-by: YueHaibing <yuehaibing at huawei.com>
> ---
> drivers/gpu/drm/mga/mga_state.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/mga/mga_state.c b/drivers/gpu/drm/mga/mga_state.c
> index 77a0b006f066..0dec4062e5a2 100644
> --- a/drivers/gpu/drm/mga/mga_state.c
> +++ b/drivers/gpu/drm/mga/mga_state.c
> @@ -942,7 +942,6 @@ static int mga_dma_iload(struct drm_device *dev, void *data, struct drm_file *fi
> struct drm_device_dma *dma = dev->dma;
> drm_mga_private_t *dev_priv = dev->dev_private;
> struct drm_buf *buf;
> - drm_mga_buf_priv_t *buf_priv;
> drm_mga_iload_t *iload = data;
> DRM_DEBUG("\n");
>
> @@ -959,7 +958,6 @@ static int mga_dma_iload(struct drm_device *dev, void *data, struct drm_file *fi
> return -EINVAL;
>
> buf = dma->buflist[iload->idx];
> - buf_priv = buf->dev_private;
>
> if (mga_verify_iload(dev_priv, iload->dstorg, iload->length)) {
> mga_freelist_put(dev, buf);
>
Thanks!
Acked-by: Thomas Zimmermann <tzimmermann at suse.de>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20190724/1e1a4b17/attachment.sig>
More information about the dri-devel
mailing list