[PATCH] mm/hmm: replace hmm_update with mmu_notifier_range

Ralph Campbell rcampbell at nvidia.com
Thu Jul 25 17:53:54 UTC 2019


On 7/24/19 6:14 PM, Jason Gunthorpe wrote:
> On Tue, Jul 23, 2019 at 02:05:06PM -0700, Ralph Campbell wrote:
>> The hmm_mirror_ops callback function sync_cpu_device_pagetables() passes
>> a struct hmm_update which is a simplified version of struct
>> mmu_notifier_range. This is unnecessary so replace hmm_update with
>> mmu_notifier_range directly.
>>
>> Signed-off-by: Ralph Campbell <rcampbell at nvidia.com>
>> Cc: "Jérôme Glisse" <jglisse at redhat.com>
>> Cc: Jason Gunthorpe <jgg at mellanox.com>
>> Cc: Christoph Hellwig <hch at lst.de>
>> Cc: Ben Skeggs <bskeggs at redhat.com>
>>
>> This is based on 5.3.0-rc1 plus Christoph Hellwig's 6 patches
>> ("hmm_range_fault related fixes and legacy API removal v2").
>> Jason, I believe this is the patch you were requesting.
> 
> Doesn't this need revision to include amgpu?
> 
> drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:         .sync_cpu_device_pagetables = amdgpu_mn_sync_pagetables_gfx,
> drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:         .sync_cpu_device_pagetables = amdgpu_mn_sync_pagetables_hsa,
> 
> Thanks,
> Jason
> 

Yes. I have added this to v2 which I'll send out with Christoph's 2 
patches and the hmm_range.vma removal patch you suggested.


More information about the dri-devel mailing list