[PATCH] drm/mst: Fix sphinx warnings in drm_dp_msg_connector register functions

Sean Paul sean at poorly.run
Fri Jul 26 18:48:55 UTC 2019


On Fri, Jul 26, 2019 at 2:06 PM Lyude Paul <lyude at redhat.com> wrote:
>
> lgtm
>
> Reviewed-by: Lyude Paul <lyude at redhat.com>
>

Thanks for the quick review! Pushed to drm-misc-next

Sean


> On Fri, 2019-07-26 at 10:20 -0400, Sean Paul wrote:
> > From: Sean Paul <seanpaul at chromium.org>
> >
> > Fixes the following warnings:
> >
> > ../drivers/gpu/drm/drm_dp_mst_topology.c:1593: warning: Excess function
> > parameter 'drm_connector' description in
> > 'drm_dp_mst_connector_late_register'
> > ../drivers/gpu/drm/drm_dp_mst_topology.c:1613: warning: Excess function
> > parameter 'drm_connector' description in
> > 'drm_dp_mst_connector_early_unregister'
> > ../drivers/gpu/drm/drm_dp_mst_topology.c:1594: warning: Function parameter
> > or member 'connector' not described in 'drm_dp_mst_connector_late_register'
> > ../drivers/gpu/drm/drm_dp_mst_topology.c:1614: warning: Function parameter
> > or member 'connector' not described in
> > 'drm_dp_mst_connector_early_unregister'
> >
> > Fixes: 562836a269e3 ("drm/dp_mst: Enable registration of AUX devices for MST
> > ports")
> > Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > Cc: Leo Li <sunpeng.li at amd.com>
> > Cc: Lyude Paul <lyude at redhat.com>
> > Cc: Harry Wentland <harry.wentland at amd.com>
> > Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> > Cc: Maxime Ripard <maxime.ripard at bootlin.com>
> > Cc: Sean Paul <sean at poorly.run>
> > Cc: David Airlie <airlied at linux.ie>
> > Cc: Daniel Vetter <daniel at ffwll.ch>
> > Cc: dri-devel at lists.freedesktop.org
> > Signed-off-by: Sean Paul <seanpaul at chromium.org>
> > ---
> >  drivers/gpu/drm/drm_dp_mst_topology.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c
> > b/drivers/gpu/drm/drm_dp_mst_topology.c
> > index d3d5fa5e50e0..82add736e17d 100644
> > --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> > +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> > @@ -1579,7 +1579,7 @@ static void build_mst_prop_path(const struct
> > drm_dp_mst_branch *mstb,
> >
> >  /**
> >   * drm_dp_mst_connector_late_register() - Late MST connector registration
> > - * @drm_connector: The MST connector
> > + * @connector: The MST connector
> >   * @port: The MST port for this connector
> >   *
> >   * Helper to register the remote aux device for this MST port. Drivers
> > should
> > @@ -1601,7 +1601,7 @@ EXPORT_SYMBOL(drm_dp_mst_connector_late_register);
> >
> >  /**
> >   * drm_dp_mst_connector_early_unregister() - Early MST connector
> > unregistration
> > - * @drm_connector: The MST connector
> > + * @connector: The MST connector
> >   * @port: The MST port for this connector
> >   *
> >   * Helper to unregister the remote aux device for this MST port, registered
> > by
> --
> Cheers,
>         Lyude Paul
>


More information about the dri-devel mailing list