[PATCH] drm/i810: Use CONFIG_PREEMPTION

Daniel Vetter daniel at ffwll.ch
Fri Jul 26 22:07:03 UTC 2019


On Fri, Jul 26, 2019 at 10:25 PM Thomas Gleixner <tglx at linutronix.de> wrote:
>
> CONFIG_PREEMPTION is selected by CONFIG_PREEMPT and by
> CONFIG_PREEMPT_RT. Both PREEMPT and PREEMPT_RT require the same
> functionality which today depends on CONFIG_PREEMPT.
>
> Change the Kconfig dependency of i810 to !CONFIG_PREEMPTION so the driver
> is not accidentally built on a RT kernel.
>
> Signed-off-by: Thomas Gleixner <tglx at linutronix.de>
> Cc: dri-devel at lists.freedesktop.org
> Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> Cc: David Airlie <airlied at linux.ie>
> Cc: Daniel Vetter <daniel at ffwll.ch>

My kernel/Kconfig.preempt here still has that as PREEMPT. Does this
patch need some others? In that case Ack for merging through whatever
tree those go in through.
-Daniel

> ---
>  drivers/gpu/drm/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -394,7 +394,7 @@ config DRM_R128
>  config DRM_I810
>         tristate "Intel I810"
>         # !PREEMPT because of missing ioctl locking
> -       depends on DRM && AGP && AGP_INTEL && (!PREEMPT || BROKEN)
> +       depends on DRM && AGP && AGP_INTEL && (!PREEMPTION || BROKEN)
>         help
>           Choose this option if you have an Intel I810 graphics card.  If M is
>           selected, the module will be called i810.  AGP support is required



-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the dri-devel mailing list