[PATCH 1/4] drm: Drop a redundant unused variable

Shankar, Uma uma.shankar at intel.com
Mon Jun 3 11:52:41 UTC 2019



>-----Original Message-----
>From: Daniel Vetter [mailto:daniel.vetter at ffwll.ch] On Behalf Of Daniel Vetter
>Sent: Monday, June 3, 2019 1:42 PM
>To: Shankar, Uma <uma.shankar at intel.com>
>Cc: intel-gfx at lists.freedesktop.org; dri-devel at lists.freedesktop.org;
>maarten.lankhorst at linux.intel.com; ville.syrjala at linux.intel.com; Sharma, Shashank
><shashank.sharma at intel.com>; emil.l.velikov at gmail.com; brian.starkey at arm.com;
>dcastagna at chromium.org; seanpaul at chromium.org; Roper, Matthew D
><matthew.d.roper at intel.com>; jonas at kwiboo.se; daniel at ffwll.ch
>Subject: Re: [PATCH 1/4] drm: Drop a redundant unused variable
>
>On Thu, May 30, 2019 at 01:29:01AM +0530, Uma Shankar wrote:
>> Drop a redundant and unused variable "hdr_output_metadata" from
>> drm_connector.
>>
>> Suggested-by: Daniel Vetter <daniel at ffwll.ch>
>> Signed-off-by: Uma Shankar <uma.shankar at intel.com>
>
>For next time around: Please add Fixes: lines to indicate which already merged
>commit you're improving.

Thanks Daniel. Sure, will take care of that in future.

Regards,
Uma Shankar

>Patch merged, thanks.
>-Daniel
>
>> ---
>>  include/drm/drm_connector.h | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
>> index f8f4003..5476561 100644
>> --- a/include/drm/drm_connector.h
>> +++ b/include/drm/drm_connector.h
>> @@ -1244,8 +1244,6 @@ struct drm_connector {
>>  	 */
>>  	struct llist_node free_node;
>>
>> -	/* HDR metdata */
>> -	struct hdr_output_metadata hdr_output_metadata;
>>  	struct hdr_sink_metadata hdr_sink_metadata;  };
>>
>> --
>> 1.9.1
>>
>
>--
>Daniel Vetter
>Software Engineer, Intel Corporation
>http://blog.ffwll.ch


More information about the dri-devel mailing list