[PATCH 1/8] drm/ast: Unpin cursor BO during cleanup

[Thomas Zimmermann]

Hi

Am 05.06.19 um 09:45 schrieb Maarten Lankhorst:
> Op 04-06-2019 om 17:41 schreef Thomas Zimmermann:
>> The unpin operation was missing from ast_cursor_fini(). Fixed now.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
>> ---
>>  drivers/gpu/drm/ast/ast_mode.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
>> index fb700d620b64..41741cd6cd15 100644
>> --- a/drivers/gpu/drm/ast/ast_mode.c
>> +++ b/drivers/gpu/drm/ast/ast_mode.c
>> @@ -959,6 +959,7 @@ static void ast_cursor_fini(struct drm_device *dev)
>>  	struct drm_gem_vram_object *gbo =
>>  		drm_gem_vram_of_gem(ast->cursor_cache);
>>  	drm_gem_vram_kunmap_at(gbo, &ast->cache_kmap);
>> +	drm_gem_vram_unpin(gbo);
>>  	drm_gem_object_put_unlocked(ast->cursor_cache);
>>  }
>>  
> 
> Fixes tag?

I didn't add one as it would be the original commit 312fec1405dd5. Since
the code is only called during driver shutdown, I don't think it ever
was a problem. Unpinning the cursor is still the correct thing to do.

Best regards
Thomas

> 
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20190605/9420b1ed/attachment.sig>