[PATCH 6/8] drm/mgag200: Rewrite cursor handling

Gerd Hoffmann kraxel at redhat.com
Wed Jun 5 09:58:17 UTC 2019


On Tue, Jun 04, 2019 at 05:41:59PM +0200, Thomas Zimmermann wrote:
> The cursor handling in mgag200 is complicated to understand. It touches a
> number of different BOs, but doesn't really use all of them.
> 
> Rewriting the cursor update reduces the amount of cursor state. There are
> two BOs for double-buffered HW updates. The source BO updates the one that
> is currently not displayed and then switches buffers. Explicit BO locking
> has been removed from the code. BOs are simply pinned and unpinned in video
> RAM.

Cursors are not that big after all, so maybe pin the two BOs for
double-buffering permanently in vram to simplify things further?

Also factoring out the code which updates the two BOs to a separate
function should help making the code more readable.

But even as-is the patch is a step into the right direction.

Acked-by: Gerd Hoffmann <kraxel at redhat.com>

cheers,
  Gerd



More information about the dri-devel mailing list