[PATCH libdrm 00/10] Add C8, 30bpp and FP16 support to modetest

Emil Velikov emil.l.velikov at gmail.com
Thu Jun 6 15:54:26 UTC 2019


On Mon, 3 Jun 2019 at 01:40, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>
> This series improves the pattern generation logic to support additional
> formats, as well as a new "gradient" pattern (see patch comments on why
> I found it useful).
>
> Furthermore, these formats are piped through to modetest, including the
> ability to set a gamma table, which is necessary for the C8 indexed
> format.
>
> This was tested on nouveau, and used for bring-up of the C8, XB30, and
> FP16 formats on the NVIDIA hardware that supports these.
>
> Ilia Mirkin (10):
>   util: add C8 format, support it with SMPTE pattern
I did not verify the numbers in this patch, but it looks reasonable:
Acked-by: Emil Velikov <emil.velikov at collabora.com>

>   util: fix MAKE_RGBA macro for 10bpp modes
>   util: add gradient pattern
>   util: add fp16 format support
>   util: add cairo drawing for 30bpp formats when available
>   modetest: don't pretend that atomic mode includes a format
There a small, would be great but not required, comment here (part of
which you addressed with in 08/10)

>   modetest: add an add_property_optional variant that does not print
>     errors
>   modetest: add C8 support to generate SMPTE pattern
>   modetest: add the ability to specify fill patterns on the commandline
>   modetest: add FP16 format support
>
Patches 2-10 are
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

-Emil


More information about the dri-devel mailing list