[PATCH 08/10] drm/vkms: No _irqsave within spin_lock_irq needed
Rodrigo Siqueira
rodrigosiqueiramelo at gmail.com
Wed Jun 12 13:43:56 UTC 2019
On Thu, Jun 6, 2019 at 7:28 PM Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
>
> irqs are already off.
>
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> ---
> drivers/gpu/drm/vkms/vkms_crtc.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vkms_crtc.c
> index b6987d90805f..48a793ba4030 100644
> --- a/drivers/gpu/drm/vkms/vkms_crtc.c
> +++ b/drivers/gpu/drm/vkms/vkms_crtc.c
> @@ -183,17 +183,16 @@ static void vkms_crtc_atomic_flush(struct drm_crtc *crtc,
> struct drm_crtc_state *old_crtc_state)
> {
> struct vkms_output *vkms_output = drm_crtc_to_vkms_output(crtc);
> - unsigned long flags;
>
> if (crtc->state->event) {
> - spin_lock_irqsave(&crtc->dev->event_lock, flags);
> + spin_lock(&crtc->dev->event_lock);
>
> if (drm_crtc_vblank_get(crtc) != 0)
> drm_crtc_send_vblank_event(crtc, crtc->state->event);
> else
> drm_crtc_arm_vblank_event(crtc, crtc->state->event);
>
> - spin_unlock_irqrestore(&crtc->dev->event_lock, flags);
> + spin_unlock(&crtc->dev->event_lock);
>
> crtc->state->event = NULL;
> }
> --
> 2.20.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Reviewed-by: Rodrigo Siqueira <rodrigosiqueiramelo at gmail.com>
Tested-by: Rodrigo Siqueira <rodrigosiqueiramelo at gmail.com>
--
Rodrigo Siqueira
https://siqueira.tech
More information about the dri-devel
mailing list