[PATCH v3 3/6] drm/modes: Allow to specify rotation and reflection on the commandline

[Maxime Ripard]

Hi,

On Wed, Jun 12, 2019 at 02:43:44PM +0200, Noralf Trønnes wrote:
> Den 11.06.2019 14.49, skrev Maxime Ripard:
> >>> +		} else if (!strncmp(option, "reflect_x", delim - option)) {
> >>> +			rotation |= DRM_MODE_REFLECT_X;
> >>> +			sep = delim;
> >>> +		} else if (!strncmp(option, "reflect_y", delim - option)) {
> >>
> >> I think you should drop reflect_x and _y for now since they're not
> >> supported. People like me that only reads code and not documentation
> >> (ahem..) will get the impression that this should work.
> >
> > I'm not sure what you mean here, this is definitely supposed to
> > work. Is there a limitation you're thinking of?
> >
>
> It's this one in drm_client_panel_rotation() which limits rotation to
> DRM_MODE_ROTATE_180:
>
> 	/*
> 	 * TODO: support 90 / 270 degree hardware rotation,
> 	 * depending on the hardware this may require the framebuffer
> 	 * to be in a specific tiling format.
> 	 */
> 	if (*rotation != DRM_MODE_ROTATE_180 || !plane->rotation_property)
> 		return false;

Indeed, it doesn't work anymore since I rebased on your work. I'll fix
this, thanks!

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20190612/199b27e3/attachment.sig>