[PATCH] i915: no need to check return value of debugfs_create functions

[Jani Nikula]

On Thu, 13 Jun 2019, Greg Kroah-Hartman <gregkh at linuxfoundation.org> wrote:
> When calling debugfs functions, there is no need to ever check the
> return value.  The function can work or not, but the code logic should
> never do something different based on this.
>
> Cc: Jani Nikula <jani.nikula at linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> Cc: David Airlie <airlied at linux.ie>
> Cc: Daniel Vetter <daniel at ffwll.ch>
> Cc: intel-gfx at lists.freedesktop.org
> Cc: dri-devel at lists.freedesktop.org
> Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>

Thanks, looks good, but for some reason this was not picked up by our
CI. I resent it with hopes we'll get some test results too.

BR,
Jani.


> ---
>  drivers/gpu/drm/i915/i915_debugfs.c | 20 +++++++-------------
>  1 file changed, 7 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 5823ffb17821..bd5cf8ec254d 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -4648,23 +4648,17 @@ static const struct i915_debugfs_files {
>  int i915_debugfs_register(struct drm_i915_private *dev_priv)
>  {
>  	struct drm_minor *minor = dev_priv->drm.primary;
> -	struct dentry *ent;
>  	int i;
>  
> -	ent = debugfs_create_file("i915_forcewake_user", S_IRUSR,
> -				  minor->debugfs_root, to_i915(minor->dev),
> -				  &i915_forcewake_fops);
> -	if (!ent)
> -		return -ENOMEM;
> +	debugfs_create_file("i915_forcewake_user", S_IRUSR, minor->debugfs_root,
> +			    to_i915(minor->dev), &i915_forcewake_fops);
>  
>  	for (i = 0; i < ARRAY_SIZE(i915_debugfs_files); i++) {
> -		ent = debugfs_create_file(i915_debugfs_files[i].name,
> -					  S_IRUGO | S_IWUSR,
> -					  minor->debugfs_root,
> -					  to_i915(minor->dev),
> -					  i915_debugfs_files[i].fops);
> -		if (!ent)
> -			return -ENOMEM;
> +		debugfs_create_file(i915_debugfs_files[i].name,
> +				    S_IRUGO | S_IWUSR,
> +				    minor->debugfs_root,
> +				    to_i915(minor->dev),
> +				    i915_debugfs_files[i].fops);
>  	}
>  
>  	return drm_debugfs_create_files(i915_debugfs_list,

-- 
Jani Nikula, Intel Open Source Graphics Center