[PATCH] malidp: no need to check return value of debugfs_create functions

[Greg Kroah-Hartman]

On Thu, Jun 13, 2019 at 03:52:22PM +0100, Liviu Dudau wrote:
> On Thu, Jun 13, 2019 at 03:28:29PM +0200, Greg Kroah-Hartman wrote:
> > When calling debugfs functions, there is no need to ever check the
> > return value.  The function can work or not, but the code logic should
> > never do something different based on this.
> 
> I remember when writing this code and testing not fully complete code that left
> nodes around on removing the module that there were errors being returned by
> debugfs_create_file(). Has that changed since 2 years ago? :)

Errors can be returned if you do something foolish:
	- pass an error as a parent pointer
	- pass a name that is already present
or if the system is out of resources
	- can not increment superblock reference
	- out of memory to create an inode

If those last two things are happening, then your system is crashing
already, debugfs is the least of your worries :)

> > Cc: Liviu Dudau <liviu.dudau at arm.com>
> > Cc: Brian Starkey <brian.starkey at arm.com>
> > Cc: David Airlie <airlied at linux.ie>
> > Cc: Daniel Vetter <daniel at ffwll.ch>
> > Cc: dri-devel at lists.freedesktop.org
> > Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> 
> Acked-by: Liviu Dudau <liviu.dudau at arm.com>
> 
> I'll pull it into the malidp tree.

Wonderful, thanks!

greg k-h