[PATCH] armada: no need to check return value of debugfs_create functions

Greg Kroah-Hartman gregkh at linuxfoundation.org
Thu Jun 13 16:01:14 UTC 2019


On Thu, Jun 13, 2019 at 03:36:00PM +0100, Russell King - ARM Linux admin wrote:
> On Thu, Jun 13, 2019 at 03:28:50PM +0200, Greg Kroah-Hartman wrote:
> > When calling debugfs functions, there is no need to ever check the
> > return value.  The function can work or not, but the code logic should
> > never do something different based on this.
> 
> Please don't merge this patch - I have a change that conflicts with this
> which switches us over to using drm_debugfs_create_files(), thereby
> eliminating this code.

Isn't it "first received, first applied?"  That's how it is for my
subsystems...

Anyway, I have a much larger patch for all users of
drm_debugfs_create_files coming, but I'll wait for all of these tiny
ones to land before sending that out :)

thanks,

greg k-h


More information about the dri-devel mailing list