[PATCH] armada: no need to check return value of debugfs_create functions

[Greg Kroah-Hartman]

On Thu, Jun 13, 2019 at 05:15:59PM +0100, Russell King - ARM Linux admin wrote:
> On Thu, Jun 13, 2019 at 06:01:14PM +0200, Greg Kroah-Hartman wrote:
> > On Thu, Jun 13, 2019 at 03:36:00PM +0100, Russell King - ARM Linux admin wrote:
> > > On Thu, Jun 13, 2019 at 03:28:50PM +0200, Greg Kroah-Hartman wrote:
> > > > When calling debugfs functions, there is no need to ever check the
> > > > return value.  The function can work or not, but the code logic should
> > > > never do something different based on this.
> > > 
> > > Please don't merge this patch - I have a change that conflicts with this
> > > which switches us over to using drm_debugfs_create_files(), thereby
> > > eliminating this code.
> > 
> > Isn't it "first received, first applied?"  That's how it is for my
> > subsystems...
> 
> When I started working on the kernel in the 1990s, it was "the most
> technically correct approach of competing approaches".  If we've
> now switched to "first received, first applied" that can only be
> harmful and demotivating to those who wish to do a good job.
> 
> If someone has a better approach ready to go, why should the
> inferior approach be applied and then the better approach have to
> be rebased on top of the inferior approach?  This makes no sense.

If you have a better approach ready to go, please post it and I will be
glad to rebase my patch on top of yours.

greg k-h