[PATCH v2 01/13] drm/i2c: tda998x: introduce tda998x_audio_settings

Russell King - ARM Linux admin linux at armlinux.org.uk
Thu Jun 13 20:36:35 UTC 2019


On Thu, Jun 13, 2019 at 02:48:47PM -0400, Sven Van Asbroeck wrote:
> Nit: checkpatch.pl appears unhappy with this patch:
> 
> WARNING: line over 80 characters
> #222: FILE: drivers/gpu/drm/i2c/tda998x_drv.c:1011:
> + audio.params.config = priv->audio_port[i].config;
> 
> WARNING: line over 80 characters
> #230: FILE: drivers/gpu/drm/i2c/tda998x_drv.c:1017:
> + audio.params.config = priv->audio_port[i].config;
> 
> total: 0 errors, 2 warnings, 178 lines checked

Considering that code is going away in the very next patch, those
warnings are not something I'm concerned about - the extra hassle
of formatting the code so checkpatch is happy only to remove it
in the next patch is not worth the effort.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up


More information about the dri-devel mailing list