[Bug 110897] HyperZ is broken for r300 (bad z for some micro and macrotiles?)
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Fri Jun 14 12:52:13 UTC 2019
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #28 from Richard Thier <u9vata at gmail.com> ---
I still see the glitches with the following changes:
@@ -364,11 +369,21 @@ static void r300_clear(struct pipe_context* pipe,
/* Clear. */
if (buffers) {
/* Clear using the blitter. */
+
+ /* FIXME: Twoline HACKZ TO SAVE FLAGS THAT blitter_clear clears */
+ bool tmp_zmask_clear_dirty = r300->zmask_clear.dirty;
+ bool tmp_hiz_clear_dirty = r300->hiz_clear.dirty;
+
r300_blitter_begin(r300, R300_CLEAR);
util_blitter_clear(r300->blitter, width, height, 1,
buffers, color, depth, stencil);
+ /* FIXME: two lines of hack! */
+ r300->zmask_clear.dirty = tmp_zmask_clear_dirty;
+ r300->hiz_clear.dirty = tmp_hiz_clear_dirty;
+
r300_blitter_end(r300);
- } else if (r300->zmask_clear.dirty ||
+/* TIPP: here maybe not else if, just an if should be present??? */
+ } /*else*/ if (r300->zmask_clear.dirty ||
r300->hiz_clear.dirty ||
r300->cmask_clear.dirty) {
Even though we are now entering the things after this if and go where the zram
clear emit is. Maybe this is not the problem...
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20190614/41deab9d/attachment.html>
More information about the dri-devel
mailing list