[PATCH v4 08/12] drm/connector: Introduce a TV margins structure

[Noralf Trønnes]

Den 14.06.2019 14.13, skrev Maxime Ripard:
> The TV margins has been defined as a structure inside the
> drm_connector_state structure so far. However, we will need it in other
> structures as well, so let's move that structure definition so that it can
> be reused.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard at bootlin.com>
> ---
>  include/drm/drm_connector.h | 34 +++++++++++++++++++++++++++++-----
>  1 file changed, 29 insertions(+), 5 deletions(-)
> 
> diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
> index 68a04169ea36..c58a35b34c1a 100644
> --- a/include/drm/drm_connector.h
> +++ b/include/drm/drm_connector.h
> @@ -464,13 +464,37 @@ int drm_display_info_set_bus_formats(struct drm_display_info *info,
>  				     unsigned int num_formats);
>  
>  /**
> + * struct drm_connector_tv_margins - TV connector related margins
> + *
> + * Describes the margins in pixels to put around the image on TV
> + * connectors to deal with overscan.
> + */
> +struct drm_connector_tv_margins {
> +	/**
> +	 * @bottom: Bottom margin in pixels.
> +	 */
> +	unsigned int bottom;
> +
> +	/**
> +	 * @left: Left margin in pixels.
> +	 */
> +	unsigned int left;
> +
> +	/**
> +	 * @right: Right margin in pixels.
> +	 */
> +	unsigned int right;
> +
> +	/**
> +	 * @top: Top margin in pixels.
> +	 */
> +	unsigned int top;
> +};
> +
> +/**
>   * struct drm_tv_connector_state - TV connector related states
>   * @subconnector: selected subconnector
> - * @margins: margins (all margins are expressed in pixels)
> - * @margins.left: left margin
> - * @margins.right: right margin
> - * @margins.top: top margin
> - * @margins.bottom: bottom margin
> + * @margins: TV margins
>   * @mode: TV mode
>   * @brightness: brightness in percent
>   * @contrast: contrast in percent
> 

The actual struct conversion is missing here, it has ended up in:

[PATCH v4 10/12] drm/modes: Parse overscan properties

With that moved in here:

Reviewed-by: Noralf Trønnes <noralf at tronnes.org>