[PATCH] staging: fbtft: Fix checkpatch ERROR: space prohibited before that close parenthesis ')'

Greg Kroah-Hartman gregkh at linuxfoundation.org
Sat Jun 15 17:33:02 UTC 2019


On Thu, Jun 13, 2019 at 07:32:28PM -0700, Shobhit Kukreti wrote:
> Cleaned up code to resolve  the checkpatch error
> ERROR: space prohibited before that close parenthesis ')'
> from the file:
> 
> fbtft/fbtft-bus.c
> 
> Signed-off-by: Shobhit Kukreti <shobhitkukreti at gmail.com>
> ---
>  drivers/staging/fbtft/fbtft-bus.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
> index 2ea814d..2b43bc2 100644
> --- a/drivers/staging/fbtft/fbtft-bus.c
> +++ b/drivers/staging/fbtft/fbtft-bus.c
> @@ -62,9 +62,9 @@ out:									      \
>  }                                                                             \
>  EXPORT_SYMBOL(func);
>  
> -define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
> +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8,)
>  define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
> -define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, )
> +define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16,)

Will this still build?  I thought I remember some old versions of gcc
not liking this...

Did you test this patch out?

thanks,

greg k-h


More information about the dri-devel mailing list