[PATCH libdrm 2/2] meson.build: Fix meson script on FreeBSD

Niclas Zeising zeising at daemonic.se
Sun Jun 16 13:52:56 UTC 2019


On 2019-06-16 15:16, Emil Velikov wrote:
> On Mon, 3 Jun 2019 at 08:41, Niclas Zeising <zeising at daemonic.se> wrote:
>>
>> FreeBSD requires sys/types.h for sys/sysctl.h, add it as part of the
>> includes when checking for headers.
>> Instead of splitting out the check for sys/sysctl.h from the other
>> header checks, just add sys/types.h to all header checks.
>>
> If header X depends on Y, then the former should include Y.
> Can you please file a FreeBSD bug?

This is how it's documented in the sysctl(3) manual on FreeBSD.  I will 
ask around why that is, but I don't expect it to change.

> 
> That said, the workaround is safe, so I'll split it out + add a comment.
> I'll send v2 in a second.
> 
>> FreeBSD doesn't normally ship bash, try regular sh instead if we can't
>> find bash.
> 
> Actually not sure why we're looking for bash. The lot works fine with
> bash, zsh, dash, ksh you-name it.
> Will include those with v2.

As long as it's only using posix stuff, FreeBSD /bin/sh should work 
fine, as should those others, I think.
I had no problems running the tests with FreeBSD /bin/sh when I tried, 
at least.
Regards
-- 
Niclas Zeising


More information about the dri-devel mailing list