[linux-sunxi] [PATCH v2 5/9] drm/sun4i: tcon_top: Register clock gates in probe
Chen-Yu Tsai
wens at csie.org
Tue Jun 18 07:53:14 UTC 2019
On Tue, Jun 18, 2019 at 3:45 PM Jagan Teki <jagan at amarulasolutions.com> wrote:
>
> On Tue, Jun 18, 2019 at 12:49 PM Chen-Yu Tsai <wens at csie.org> wrote:
> >
> > On Mon, Jun 17, 2019 at 6:30 PM Jagan Teki <jagan at amarulasolutions.com> wrote:
> > >
> > > On Sun, Jun 16, 2019 at 11:01 AM Chen-Yu Tsai <wens at csie.org> wrote:
> > > >
> > > > On Sat, Jun 15, 2019 at 12:44 AM Jagan Teki <jagan at amarulasolutions.com> wrote:
> > > > >
> > > > > TCON TOP have clock gates for TV0, TV1, dsi and right
> > > > > now these are register during bind call.
> > > > >
> > > > > Of which, dsi clock gate would required during DPHY probe
> > > > > but same can miss to get since tcon top is not bound at
> > > > > that time.
> > > > >
> > > > > To solve, this circular dependency move the clock gate
> > > > > registration from bind to probe so-that DPHY can get the
> > > > > dsi gate clock on time.
> > > > >
> > > > > Signed-off-by: Jagan Teki <jagan at amarulasolutions.com>
> > > > > ---
> > > > > drivers/gpu/drm/sun4i/sun8i_tcon_top.c | 94 ++++++++++++++------------
> > > > > 1 file changed, 49 insertions(+), 45 deletions(-)
> > > > >
> > > > > diff --git a/drivers/gpu/drm/sun4i/sun8i_tcon_top.c b/drivers/gpu/drm/sun4i/sun8i_tcon_top.c
> > > > > index 465e9b0cdfee..a8978b3fe851 100644
> > > > > --- a/drivers/gpu/drm/sun4i/sun8i_tcon_top.c
> > > > > +++ b/drivers/gpu/drm/sun4i/sun8i_tcon_top.c
> > > > > @@ -124,7 +124,53 @@ static struct clk_hw *sun8i_tcon_top_register_gate(struct device *dev,
> > > > > static int sun8i_tcon_top_bind(struct device *dev, struct device *master,
> > > > > void *data)
> > > > > {
> > > > > - struct platform_device *pdev = to_platform_device(dev);
> > > > > + struct sun8i_tcon_top *tcon_top = dev_get_drvdata(dev);
> > > > > + int ret;
> > > > > +
> > > > > + ret = reset_control_deassert(tcon_top->rst);
> > > > > + if (ret) {
> > > > > + dev_err(dev, "Could not deassert ctrl reset control\n");
> > > > > + return ret;
> > > > > + }
> > > > > +
> > > > > + ret = clk_prepare_enable(tcon_top->bus);
> > > > > + if (ret) {
> > > > > + dev_err(dev, "Could not enable bus clock\n");
> > > > > + goto err_assert_reset;
> > > > > + }
> > > >
> > > > You have to de-assert the reset control and enable the clock before the
> > > > clocks it provides are registered. Otherwise a consumer may come in and
> > > > ask for the provided clock to be enabled, but since the TCON TOP's own
> > > > reset and clock are still disabled, you can't actually access the registers
> > > > that controls the provided clock.
> > >
> > > These rst and bus are common reset and bus clocks not tcon top clocks
> > > that are trying to register here. ie reason I have not moved it in
> > > top.
> >
> > And you're sure that toggling bits in the TCON TOP block doesn't require
> > the reset to be de-asserted and the bus clock enabled?
> >
> > Somehow I doubt that.
> >
> > Once the driver register the clocks it provides, they absolutely must work.
> > They can't only work after the bind phase when the reset gets de-asserted
> > and the bus clock enabled. Or you should provide proper error reporting
> > in the clock ops. I doubt you want to go that way either.
>
> Why would they won't work after bind phase? unlike tcon top gates,
> these reset, and bus are common like what we have in other DE block
> so enable them in bind won't be an issue as per as I understand. let
> me know if you want me to check in other directions.
You misunderstood. When you moved the clock registering parts to the probe
phase, but didn't move the clock enable and reset de-assert parts to go with,
the clock ops will not work as expected between probe and bind time.
Simple way to verify it: Just use devmem to disable the TCON TOP bus gate
and/or assert its reset control. Then try to toggle any of the bits in the
TCON TOP block and see if it works, or if the bits stick.
Whether another driver actually does so is not the question. It is just bad
implementation.
> Log:
> [ 1.381410] sun6i-mipi-dsi 1ca0000.dsi: Attached panel s070wv20-ct16-icn62
> [ 1.398405] sun4i-drm display-engine: bound 1100000.mixer (ops 0xc074ce64)
> [ 1.407134] sun4i-drm display-engine: bound 1200000.mixer (ops 0xc074ce64)
> [ 1.414043] sun4i-drm display-engine: bound 1c70000.tcon-top (ops 0xc0750e80)
> [ 1.421407] sun4i_dclk_recalc_rate: val = 1, rate = 297000000
> [ 1.427358] sun4i-drm display-engine: No panel or bridge found...
> RGB output disabled
> [ 1.435217] sun4i-drm display-engine: bound 1c71000.lcd-controller
> (ops 0xc0749594)
> [ 1.442891] 0.0 drm_connector_init
> [ 1.446294] 0. -1066106880-1-0 (null)
> [ 1.449965] 0.1 drm_connector_init
> [ 1.453368] 0.2 drm_connector_init
> [ 1.456768] 1. drm_connector_init
> [ 1.460094] 2. drm_connector_init
> [ 1.463413] drm_connector_init: connector name = DSI-1
> [ 1.468560] sun4i-drm display-engine: bound 1ca0000.dsi (ops 0xc074c0e4)
> [ 1.475272] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013).
> [ 1.481892] [drm] No driver support for vblank timestamp query.
> [ 1.488240] [drm] Initialized sun4i-drm 1.0.0 20150629 for
> display-engine on minor 0
> [ 1.497996] sun4i_dclk_round_rate: min_div = 6 max_div = 6, rate = 30000000
> [ 1.498106] ideal = 1800000, rounded = 180000000
> [ 1.498111] sun4i_dclk_round_rate: div = 6 rate = 29700000
> [ 1.498116] sun4i_dclk_round_rate: min_div = 6 max_div = 6, rate = 30000000
> [ 1.498154] ideal = 1800000, rounded = 180000000
> [ 1.498158] sun4i_dclk_round_rate: div = 6 rate = 29700000
> [ 1.498217] sun4i_dclk_recalc_rate: val = 1, rate = 178200000
> [ 1.498251] rate = 178200000
> [ 1.498253] parent_rate = 297000000
> [ 1.498256] reg = 0x80c00000
> [ 1.498259] _nkm.n = 3, nkm->n.offset = 0x1, nkm->n.shift = 8
> [ 1.498262] _nkm.k = 2, nkm->k.offset = 0x1, nkm->k.shift = 4
> [ 1.498265] _nkm.m = 10, nkm->m.offset = 0x1, nkm->m.shift = 0
> [ 1.499594] sun4i_dclk_set_rate div 6
> [ 1.499603] sun4i_dclk_recalc_rate: val = 6, rate = 29700000
> [ 1.499680] sun6i_dsi_get_video_start_delay: delay = 513
> [ 1.499687] sun6i_dsi_setup_inst_loop: delay = 49
> [ 1.499706] hsa = 134, hbp = 114, hfp = 114, hblk = 2630, vblk = 0
> [ 1.509103] mmc0: host does not support reading read-only switch,
> assuming write-enable
> [ 1.512693] mmc0: new high speed SDHC card at address 4001
> [ 1.513723] mmcblk0: mmc0:4001 R04GS 3.71 GiB
> [ 1.515577] mmcblk0: p1 p2
> [ 1.658838] mmc2: new DDR MMC card at address 0001
> [ 1.659934] mmcblk2: mmc2:0001 8WPD3R 7.28 GiB
> [ 1.660657] mmcblk2boot0: mmc2:0001 8WPD3R partition 1 4.00 MiB
> [ 1.661387] mmcblk2boot1: mmc2:0001 8WPD3R partition 2 4.00 MiB
> [ 1.819586] TYPE#0x23, BYTE0#0x7a00, BYTE1#0xc10000
> [ 1.849570] TYPE#0x23, BYTE0#0x2000, BYTE1#0x200000
> [ 1.879569] TYPE#0x23, BYTE0#0x2100, BYTE1#0xe00000
> [ 1.909580] TYPE#0x23, BYTE0#0x2200, BYTE1#0x130000
> [ 1.939569] TYPE#0x23, BYTE0#0x2300, BYTE1#0x280000
> [ 1.969569] TYPE#0x23, BYTE0#0x2400, BYTE1#0x300000
> [ 1.999569] TYPE#0x23, BYTE0#0x2500, BYTE1#0x280000
> [ 2.029569] TYPE#0x23, BYTE0#0x2600, BYTE1#0x0
> [ 2.059569] TYPE#0x23, BYTE0#0x2700, BYTE1#0xd0000
> [ 2.089598] TYPE#0x23, BYTE0#0x2800, BYTE1#0x30000
> [ 2.119579] TYPE#0x23, BYTE0#0x2900, BYTE1#0x1d0000
> [ 2.149569] TYPE#0x23, BYTE0#0x3400, BYTE1#0x800000
> [ 2.179569] TYPE#0x23, BYTE0#0x3600, BYTE1#0x280000
> [ 2.209569] TYPE#0x23, BYTE0#0xb500, BYTE1#0xa00000
> [ 2.239569] TYPE#0x23, BYTE0#0x5c00, BYTE1#0xff0000
> [ 2.269569] TYPE#0x23, BYTE0#0x2a00, BYTE1#0x10000
> [ 2.299569] TYPE#0x23, BYTE0#0x5600, BYTE1#0x920000
> [ 2.329578] TYPE#0x23, BYTE0#0x6b00, BYTE1#0x710000
> [ 2.359569] TYPE#0x23, BYTE0#0x6900, BYTE1#0x2b0000
> [ 2.389569] TYPE#0x23, BYTE0#0x1000, BYTE1#0x400000
> [ 2.419569] TYPE#0x23, BYTE0#0x1100, BYTE1#0x980000
> [ 2.449569] TYPE#0x23, BYTE0#0xb600, BYTE1#0x200000
> [ 2.479569] TYPE#0x23, BYTE0#0x5100, BYTE1#0x200000
> [ 2.509569] TYPE#0x23, BYTE0#0x900, BYTE1#0x100000
> [ 2.679570] TYPE#0x5, BYTE0#0x2900, BYTE1#0x940000
> [ 2.767213] Console: switching to colour frame buffer device 100x30
> [ 3.144604] sun4i-drm display-engine: fb0: sun4i-drmdrmfb frame buffer device
>
> --
> You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe at googlegroups.com.
> To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/CAMty3ZBUrGEi%2Be62sFe7GkXinK3q076sGLwpEVz67qeoV%2B1ZeA%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
More information about the dri-devel
mailing list