[PATCH 1/3] drm/stm: drv: fix suspend/resume

Emil Velikov emil.l.velikov at gmail.com
Thu Jun 20 17:12:16 UTC 2019


Hi Yannick,

On Mon, 17 Jun 2019 at 08:18, Yannick Fertré <yannick.fertre at st.com> wrote:

> @@ -155,15 +154,17 @@ static __maybe_unused int drv_resume(struct device *dev)
>         struct ltdc_device *ldev = ddev->dev_private;
>         int ret;
>
> +       if (WARN_ON(!ldev->suspend_state))
> +               return -ENOENT;
> +
>         pm_runtime_force_resume(dev);
>         ret = drm_atomic_helper_resume(ddev, ldev->suspend_state);
> -       if (ret) {
> +       if (ret)
Hmm the msm driver uses !ret here. Suspecting that you want the same,
although I haven't checked in detail.

HTH
-Emil


More information about the dri-devel mailing list