[PATCH v2 1/1] drm/exynos: drop drmP.h usage

Sam Ravnborg sam at ravnborg.org
Fri Jun 21 11:05:18 UTC 2019


Hi Inki.
> --- snip ---
> > diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> > index c20b3a759370..ff9342737a51 100644
> > --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> > +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> > @@ -7,21 +7,21 @@
> >   * published by the Free Software Foundationr
> >   */
> >
> > -#include <linux/kernel.h>
> >  #include <linux/clk.h>
> >  #include <linux/component.h>
> > +#include <linux/dma-mapping.h>
> >  #include <linux/err.h>
> >  #include <linux/interrupt.h>
> >  #include <linux/io.h>
> > +#include <linux/kernel.h>
> > +#include <linux/of.h>
> >  #include <linux/platform_device.h>
> >  #include <linux/pm_runtime.h>
> >  #include <linux/slab.h>
> >  #include <linux/workqueue.h>
> > -#include <linux/dma-mapping.h>
> > -#include <linux/of.h>
> >
> > -#include <drm/drmP.h>
> >  #include <drm/exynos_drm.h>
> > +
> 
> With this patch, many build errors happen.
> 
> Seems you missed to include below header files,
> <linux/uaccess.h>
> <linux/delay.h>
> <drm/drm_file.h>
Thanks for testing, glad this was catched before it hit drm-misc.
I will try to reproduce and get back if I fails to do so.

Smells like I failed to apply some local changes or something.

	Sam


More information about the dri-devel mailing list