[PATCH v3 0/1] drm/exynos: drop use of drmP.h

[Krzysztof Kozlowski]

On Sat, 22 Jun 2019 at 09:31, Sam Ravnborg <sam at ravnborg.org> wrote:
>
> Hi Krzysztof.
>
> > > Build tested using allyesconfig, allmodconfig for various
> > > architectures.
> >
> > Hi,
> >
> > Thanks for fixes. Just for the record, allyesconfig/allmodconfig are
> > not a proper way for build test specific drivers. They are nice but
> > since all dependencies are in, they might miss a lot. You should build
> > mentioned platform (exynos_defconfig on ARMv7, defconfig on ARMv8) and
> > multi configs (multi_v7 on ARMv7). Such rule is also valid for other
> > drivers, not specific to Exynos.
>
> Thanks for the feedback. I have added exynos_defconfig,
> multi_v7_defconfig to my growing list of configs that I try when doing
> cross driver changes.
> They include defconfig + allnoconfig for the supported archs too.
>
> None of these configs would have triggered a build of exynos_drm_g2d.c
> so to do that some manual twaeks of the confg was necessary.
>
> Adding a COMPILE_TEST dependency will enable the build
> for the allyesconfig, allmodconfig.
> Thats worths to consider to avoid future mistakes.
>
>         Sam
>
> Something like this:
>
> From 9b29b85f25f4cc485f36efb8d658766fa9a252d9 Mon Sep 17 00:00:00 2001
> From: Sam Ravnborg <sam at ravnborg.org>
> Date: Sat, 22 Jun 2019 09:24:06 +0200
> Subject: [PATCH v1] drm/exynos: trigger build of all modules
>
> Add COMPILE_TEST dependency to a few options to trigger that the modules
> get built using allyesconfig, allmodconfig.
> This allows a non-exynos developer to catch build issues
> in files that is usually not built.
>
> Signed-off-by: Sam Ravnborg <sam at ravnborg.org>
> Cc: Inki Dae <inki.dae at samsung.com>
> Cc: Joonyoung Shim <jy0922.shim at samsung.com>
> Cc: Seung-Woo Kim <sw0312.kim at samsung.com>
> Cc: Kyungmin Park <kyungmin.park at samsung.com>
> Cc: David Airlie <airlied at linux.ie>
> Cc: Daniel Vetter <daniel at ffwll.ch>
> Cc: Kukjin Kim <kgene at kernel.org>
> Cc: Krzysztof Kozlowski <krzk at kernel.org>
> Cc: Jingoo Han <jingoohan1 at gmail.com>
> ---
>  drivers/gpu/drm/exynos/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig
> index cbe58d307d1c..eadea2daf1ab 100644
> --- a/drivers/gpu/drm/exynos/Kconfig
> +++ b/drivers/gpu/drm/exynos/Kconfig
> @@ -86,7 +86,7 @@ comment "Sub-drivers"
>
>  config DRM_EXYNOS_G2D
>         bool "G2D"
> -       depends on VIDEO_SAMSUNG_S5P_G2D=n
> +       depends on VIDEO_SAMSUNG_S5P_G2D=n || COMPILE_TEST

Oh yes, that definitely makes sense (assuming it compiles on all
archs). Maybe you can send a follow up adding these?

Best regards,
Krzysztof