[PATCH v1 1/2] drm/i2c: tda998x: access chip registers via a regmap

Sven Van Asbroeck thesven73 at gmail.com
Fri Jun 21 21:13:33 UTC 2019


On Fri, Jun 21, 2019 at 11:15 AM Russell King - ARM Linux admin
<linux at armlinux.org.uk> wrote:
>
> Another con is the need to keep the functions that detail the register
> properties up to date, which if they're wrong may result in unexpected
> behaviour.
>
> I subscribe to the "keep it simple" approach, and regmap, although
> useful, seems like a giant sledgehammer for this.
>

Thank you for the review !

I added this back when I was debugging audio artifacts related to this
chip. The regmap's debugfs binding was extremely useful. So I
dressed it up a bit in the hope that it would have some general use.

But if the cons outweigh the pros, then this is as far as this patch
will go...


More information about the dri-devel mailing list