[PATCH v1 1/2] drm/vmwgfx: drop use of drmP.h in header files

Mon Jun 24 21:07:21 UTC 2019

Hi Sam,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.2-rc6 next-20190621]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Sam-Ravnborg/drm-vmwgfx-drop-use-of-drmP-h-in-header-files/20190622-234524
config: x86_64-randconfig-u0-06250015 (attached as .config)
compiler: gcc-5 (Debian 5.5.0-3) 5.4.1 20171010
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp at intel.com>

All errors (new ones prefixed by >>):

   drivers/gpu/drm/vmwgfx/vmwgfx_mob.c: In function 'vmw_mob_build_pt':
>> drivers/gpu/drm/vmwgfx/vmwgfx_mob.c:517:22: error: implicit declaration of function 'kmap_atomic' [-Werror=implicit-function-declaration]
      save_addr = addr = kmap_atomic(page);
                         ^
   drivers/gpu/drm/vmwgfx/vmwgfx_mob.c:517:20: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
      save_addr = addr = kmap_atomic(page);
                       ^
>> drivers/gpu/drm/vmwgfx/vmwgfx_mob.c:526:3: error: implicit declaration of function 'kunmap_atomic' [-Werror=implicit-function-declaration]
      kunmap_atomic(save_addr);
      ^
   cc1: some warnings being treated as errors

vim +/kmap_atomic +517 drivers/gpu/drm/vmwgfx/vmwgfx_mob.c

3530bdc3 Thomas Hellstrom 2012-11-21  491  
3530bdc3 Thomas Hellstrom 2012-11-21  492  /*
3530bdc3 Thomas Hellstrom 2012-11-21  493   * vmw_mob_build_pt - Build a pagetable
3530bdc3 Thomas Hellstrom 2012-11-21  494   *
0fd53cfb Thomas Hellstrom 2013-10-24  495   * @data_addr:      Array of DMA addresses to the underlying buffer
3530bdc3 Thomas Hellstrom 2012-11-21  496   *                  object's data pages.
3530bdc3 Thomas Hellstrom 2012-11-21  497   * @num_data_pages: Number of buffer object data pages.
3530bdc3 Thomas Hellstrom 2012-11-21  498   * @pt_pages:       Array of page pointers to the page table pages.
3530bdc3 Thomas Hellstrom 2012-11-21  499   *
3530bdc3 Thomas Hellstrom 2012-11-21  500   * Returns the number of page table pages actually used.
3530bdc3 Thomas Hellstrom 2012-11-21  501   * Uses atomic kmaps of highmem pages to avoid TLB thrashing.
3530bdc3 Thomas Hellstrom 2012-11-21  502   */
0fd53cfb Thomas Hellstrom 2013-10-24  503  static unsigned long vmw_mob_build_pt(struct vmw_piter *data_iter,
3530bdc3 Thomas Hellstrom 2012-11-21  504  				      unsigned long num_data_pages,
0fd53cfb Thomas Hellstrom 2013-10-24  505  				      struct vmw_piter *pt_iter)
3530bdc3 Thomas Hellstrom 2012-11-21  506  {
3530bdc3 Thomas Hellstrom 2012-11-21  507  	unsigned long pt_size = num_data_pages * VMW_PPN_SIZE;
3530bdc3 Thomas Hellstrom 2012-11-21  508  	unsigned long num_pt_pages = DIV_ROUND_UP(pt_size, PAGE_SIZE);
0fd53cfb Thomas Hellstrom 2013-10-24  509  	unsigned long pt_page;
b9eb1a61 Thomas Hellstrom 2015-04-02  510  	u32 *addr, *save_addr;
3530bdc3 Thomas Hellstrom 2012-11-21  511  	unsigned long i;
0fd53cfb Thomas Hellstrom 2013-10-24  512  	struct page *page;
3530bdc3 Thomas Hellstrom 2012-11-21  513  
3530bdc3 Thomas Hellstrom 2012-11-21  514  	for (pt_page = 0; pt_page < num_pt_pages; ++pt_page) {
0fd53cfb Thomas Hellstrom 2013-10-24  515  		page = vmw_piter_page(pt_iter);
0fd53cfb Thomas Hellstrom 2013-10-24  516  
0fd53cfb Thomas Hellstrom 2013-10-24 @517  		save_addr = addr = kmap_atomic(page);
3530bdc3 Thomas Hellstrom 2012-11-21  518  
3530bdc3 Thomas Hellstrom 2012-11-21  519  		for (i = 0; i < PAGE_SIZE / VMW_PPN_SIZE; ++i) {
f2a0dcb1 Thomas Hellstrom 2014-01-15  520  			vmw_mob_assign_ppn(&addr,
f2a0dcb1 Thomas Hellstrom 2014-01-15  521  					   vmw_piter_dma_addr(data_iter));
0fd53cfb Thomas Hellstrom 2013-10-24  522  			if (unlikely(--num_data_pages == 0))
3530bdc3 Thomas Hellstrom 2012-11-21  523  				break;
0fd53cfb Thomas Hellstrom 2013-10-24  524  			WARN_ON(!vmw_piter_next(data_iter));
3530bdc3 Thomas Hellstrom 2012-11-21  525  		}
3530bdc3 Thomas Hellstrom 2012-11-21 @526  		kunmap_atomic(save_addr);
0fd53cfb Thomas Hellstrom 2013-10-24  527  		vmw_piter_next(pt_iter);
3530bdc3 Thomas Hellstrom 2012-11-21  528  	}
3530bdc3 Thomas Hellstrom 2012-11-21  529  
3530bdc3 Thomas Hellstrom 2012-11-21  530  	return num_pt_pages;
3530bdc3 Thomas Hellstrom 2012-11-21  531  }
3530bdc3 Thomas Hellstrom 2012-11-21  532  

:::::: The code at line 517 was first introduced by commit
:::::: 0fd53cfb09108c33b924b069fe2c62fa4e7b11a0 drm/vmwgfx: Use the linux DMA api also for MOBs

:::::: TO: Thomas Hellstrom <thellstrom at vmware.com>
:::::: CC: Thomas Hellstrom <thellstrom at vmware.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 32684 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20190625/17116b71/attachment-0001.gz>