[PATCH] [v8, 2/2] drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel

[Sam Ravnborg]

Hi Jerry.

On Thu, Apr 25, 2019 at 11:27:12AM +0800, Jerry Han wrote:
> Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI
> panel.
> 
> 
> Signed-off-by: Jerry Han <jerry.han.hq at gmail.com>
> Reviewed-by: Sam Ravnborg <sam at ravnborg.org>
> Reviewed-by: Derek Basehore <dbasehore at chromium.org>
> Cc: Jitao Shi <jitao.shi at mediatek.com>
> Cc: Rock wang <rock_wang at himax.com.cn>
> ---
>  MAINTAINERS                                  |    6 +
>  drivers/gpu/drm/panel/Kconfig                |   11 +
>  drivers/gpu/drm/panel/Makefile               |    1 +
>  drivers/gpu/drm/panel/panel-boe-himax8279d.c | 1050 ++++++++++++++++++
>  4 files changed, 1068 insertions(+)
>  create mode 100644 drivers/gpu/drm/panel/panel-boe-himax8279d.c

When applying this patch I got the following warnings.
Please fix them, and double check that checkpatch is happy.
(Some warnings can be safely ignored but trivial ones like these needs
fixing).

	Sam

-:211: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#211: FILE: drivers/gpu/drm/panel/panel-boe-himax8279d.c:95:
+			err = mipi_dsi_dcs_write(pinfo->link,
+						    cmd->data[1], NULL, 0);

-:214: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#214: FILE: drivers/gpu/drm/panel/panel-boe-himax8279d.c:98:
+			err = mipi_dsi_dcs_write(pinfo->link,
+						    cmd->data[1], cmd->data + 2,

-:221: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#221: FILE: drivers/gpu/drm/panel/panel-boe-himax8279d.c:105:
+		usleep_range((cmd->data[0]) * 1000,
+			    (1 + cmd->data[0]) * 1000);

-:250: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#250: FILE: drivers/gpu/drm/panel/panel-boe-himax8279d.c:134:
+		DRM_DEV_ERROR(panel->dev,
+				"failed to send DCS Off Code: %d\n", err);

-:295: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#295: FILE: drivers/gpu/drm/panel/panel-boe-himax8279d.c:179:
+		DRM_DEV_ERROR(panel->dev,
+				"failed to send DCS Init Code: %d\n", err);

-:319: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#319: FILE: drivers/gpu/drm/panel/panel-boe-himax8279d.c:203:
+		DRM_DEV_ERROR(panel->drm->dev,
+				"Failed to enable backlight %d\n", ret);

-:337: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#337: FILE: drivers/gpu/drm/panel/panel-boe-himax8279d.c:221:
+		DRM_DEV_ERROR(panel->drm->dev, "failed to add mode %ux%u@%u\n",
+				m->hdisplay, m->vdisplay, m->vrefresh);

-:1050: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1050: FILE: drivers/gpu/drm/panel/panel-boe-himax8279d.c:934:
+			DRM_DEV_ERROR(dev, "failed to get pp18 gpio: %d\n",
+					ret);

-:1059: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1059: FILE: drivers/gpu/drm/panel/panel-boe-himax8279d.c:943:
+			DRM_DEV_ERROR(dev, "failed to get pp33 gpio: %d\n",
+					ret);

-:1064: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1064: FILE: drivers/gpu/drm/panel/panel-boe-himax8279d.c:948:
+	pinfo->enable_gpio = devm_gpiod_get_optional(dev, "enable",
+							GPIOD_OUT_HIGH);

-:1069: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1069: FILE: drivers/gpu/drm/panel/panel-boe-himax8279d.c:953:
+			DRM_DEV_ERROR(dev, "failed to get enable gpio: %d\n",
+					ret);

-:1128: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1128: FILE: drivers/gpu/drm/panel/panel-boe-himax8279d.c:1012:
+		DRM_DEV_ERROR(&dsi->dev, "failed to unprepare panel: %d\n",
+				err);

-:1137: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1137: FILE: drivers/gpu/drm/panel/panel-boe-himax8279d.c:1021:
+		DRM_DEV_ERROR(&dsi->dev, "failed to detach from DSI host: %d\n",
+				err);