[Linux-kernel-mentees][PATCH v2] drm/amdkfd: Fix undefined behavior in bit shift
Shuah Khan
skhan at linuxfoundation.org
Thu Jun 27 03:33:43 UTC 2019
On 6/26/19 9:25 PM, Jiunn Chang wrote:
> Shifting signed 32-bit value by 31 bits is undefined. Changing most
> significant bit to unsigned.
>
> Changes included in v2:
> - use subsystem specific subject lines
> - CC required mailing lists
>
> Signed-off-by: Jiunn Chang <c0d1n61at3 at gmail.com>
> ---
Move version change lines here.
> include/uapi/linux/kfd_ioctl.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/kfd_ioctl.h b/include/uapi/linux/kfd_ioctl.h
> index dc067ed0b72d..ae5669272303 100644
> --- a/include/uapi/linux/kfd_ioctl.h
> +++ b/include/uapi/linux/kfd_ioctl.h
> @@ -339,7 +339,7 @@ struct kfd_ioctl_acquire_vm_args {
> #define KFD_IOC_ALLOC_MEM_FLAGS_USERPTR (1 << 2)
> #define KFD_IOC_ALLOC_MEM_FLAGS_DOORBELL (1 << 3)
> /* Allocation flags: attributes/access options */
> -#define KFD_IOC_ALLOC_MEM_FLAGS_WRITABLE (1 << 31)
> +#define KFD_IOC_ALLOC_MEM_FLAGS_WRITABLE (1U << 31)
> #define KFD_IOC_ALLOC_MEM_FLAGS_EXECUTABLE (1 << 30)
> #define KFD_IOC_ALLOC_MEM_FLAGS_PUBLIC (1 << 29)
> #define KFD_IOC_ALLOC_MEM_FLAGS_NO_SUBSTITUTE (1 << 28)
>
thanks,
-- Shuah
More information about the dri-devel
mailing list