[PATCH] [v2, 2/2] drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel

Sam Ravnborg sam at ravnborg.org
Sun Mar 3 19:54:59 UTC 2019


Hi Jerry

One more small comment.

> +
> +	pinfo->reset_gpio = devm_gpiod_get_optional(dev, "enable",
> +						    GPIOD_OUT_LOW);
> +	if (IS_ERR(pinfo->reset_gpio)) {
> +		err = PTR_ERR(pinfo->reset_gpio);
> +		dev_err(dev, "failed to get enable gpio: %d\n", err);
> +		pinfo->reset_gpio = NULL;
> +	}

It is confusing that in the binding the name is "enable" but
the gpio is named "reset_gpio".
If you had used "enable_gpio" then this had been more obvious.

	Sam


More information about the dri-devel mailing list