[PATCH] [v2, 1/2] dt-bindings: panel: Add Boe Himax8279d is 1200x1920, 4-lane MIPI-DSI LCD panel

Sam Ravnborg sam at ravnborg.org
Sun Mar 3 19:57:15 UTC 2019


Hi Jerry.

Thanks for the nice patch.

On Fri, Mar 01, 2019 at 04:50:48PM +0800, Jerry Han wrote:
> Add dt-bingings for it.
> 
> Signed-off-by: Jerry Han <hanxu5 at huaqin.corp-partner.google.com>

One general comment.
In the kernel (at least in drm sub-system) the changelog should be complete.
Do not expect the reader to read $subject and continue with the changelog.
It is better to repeat yourself a little.

And then please be a bit more verbose - so the cangelog capture what you are doing (and why).

	Sam


More information about the dri-devel mailing list