[RFC PATCH] drm/panfrost: Add initial panfrost driver

[Rob Herring]

On Fri, Mar 8, 2019 at 2:18 AM Neil Armstrong <narmstrong at baylibre.com> wrote:
>
> On 08/03/2019 06:00, Alyssa Rosenzweig wrote:
> > Oh my onions, it's really here! It's really coming! It's really here!
> >
> > ----
> >
>
> <snip>
>
> >
> >> +static const struct of_device_id dt_match[] = {
> >> +    { .compatible = "arm,mali-t760" },
> >> +    { .compatible = "arm,mali-t860" },
> >> +    {}
> >> +};
> >
> > Do we want to add compatibles for the rest of the Mali's on the initial
> > merge, or wait until they're actually confirmed working so we don't load
> > and cause problems on untested hardware?
>
> We should definitely stick to the midgard bindings here and add all the compatibles
> even if we haven't tested yet, maybe by adding a warning mechanism reporting
> when used on an untested mali core ?

Compatibles is the only thing we have documenting what's tested or
not. So either we add compatibles when tested or remove warnings when
tested? Either way a kernel update is needed.

> BTW rob, I resent the bifrost binding doc with an unique, "arm,mali-bifrost"
> compatible, adding it would help starting debugging bifrost aswell !

There's a lot missing for bifrost, and a compatible string is the
least of it. I can probably add most of it, but can't test any of it
(and no one can as the mesa side is not done).

>
> >
> >> +enum base_hw_feature {
> >       ...
> >> +    HW_FEATURE_PROTECTED_MODE
> >       ...
> >> +};
>
> <snip>
>
> >
> > ----------------------------
> >
> > Overall, I'm super happy to see this! Nice work, guys! ^_^
>
> Yeah pretty cool work !
>
> I'll run it on a T820 ASAP and push fixes on the gitlab repo.

What SoC is that?

Rob