[RFC PATCH] drm/panfrost: Add initial panfrost driver

Rob Herring robh at kernel.org
Fri Mar 8 14:51:46 UTC 2019


On Fri, Mar 8, 2019 at 2:20 AM Neil Armstrong <narmstrong at baylibre.com> wrote:
>
> On 08/03/2019 01:24, Rob Herring wrote:
> > From: "Marty E. Plummer" <hanetzer at startmail.com>
> >
> > This adds the initial driver for panfrost which supports Arm Mali
> > Midgard and Bifrost family of GPUs. Currently, only the T860 Midgard GPU
> > has been tested.
> >
> > Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> > Cc: Maxime Ripard <maxime.ripard at bootlin.com>
> > Cc: Sean Paul <sean at poorly.run>
> > Cc: David Airlie <airlied at linux.ie>
> > Cc: Daniel Vetter <daniel at ffwll.ch>
> > Cc: Alyssa Rosenzweig <alyssa at rosenzweig.io>
> > Cc: Lyude Paul <lyude at redhat.com>
> > Cc: Eric Anholt <eric at anholt.net>
> > Signed-off-by: Marty E. Plummer <hanetzer at startmail.com>
> > Signed-off-by: Tomeu Vizoso <tomeu.vizoso at collabora.com>
> > Signed-off-by: Rob Herring <robh at kernel.org>
> > ---
>
> <snip>
>
> > +
> > +static const struct panfrost_model gpu_models[] = {
> > +     /* T60x has an oddball version */
> > +     GPU_MODEL(t600, 0x6956, 0xffff,
> > +             GPU_REV_EXT(t600, 0, 0, 1, _15dev0)),
> > +     GPU_MODEL_MIDGARD(t620, 0x620,
> > +             GPU_REV(t620, 0, 1), GPU_REV(t620, 1, 0)),
> > +     GPU_MODEL_MIDGARD(t720, 0x720),
> > +     GPU_MODEL_MIDGARD(t760, 0x750,
> > +             GPU_REV(t760, 0, 0), GPU_REV(t760, 0, 1),
> > +             GPU_REV_EXT(t760, 0, 1, 0, _50rel0),
> > +             GPU_REV(t760, 0, 2), GPU_REV(t760, 0, 3)),
> > +     GPU_MODEL_MIDGARD(t820, 0x820),
> > +     GPU_MODEL_MIDGARD(t830, 0x830),
> > +     GPU_MODEL_MIDGARD(t860, 0x860),
> > +     GPU_MODEL_MIDGARD(t880, 0x880),
> > +
> > +     GPU_MODEL_BIFROST(g71, 0x6000,
> > +             GPU_REV_EXT(g71, 0, 0, 1, _05dev0)),
> > +     GPU_MODEL_BIFROST(g72, 0x6001),
> > +     GPU_MODEL_BIFROST(g51, 0x7000),
> > +     GPU_MODEL_BIFROST(g76, 0x7001),
> > +     GPU_MODEL_BIFROST(g52, 0x7002),
> > +     GPU_MODEL_BIFROST(g31, 0x7003,
> > +             GPU_REV(g31, 1, 0)),
>
> G31 r0p0 should be supported, the Amlogic G12A has it :
>
> [   98.036507] mali ffe40000.gpu: GPU identified as 0x3 arch 7.0.9 r0p0 status 0
>
> as reported by mali_kbase.

It is. There are no h/w issues specific to r0p0 that the kernel has to
care about. Somehow, r1p0 added a new issue.

We aren't tracking exactly all known and supported versions. Userspace
can do this if we want as the kernel doesn't even track all the
issues. If we were to have exact matching, we should only add the ones
found in h/w supported upstream. I imagine there's lots of revisions
in the kbase driver we'll never see.

Rob


More information about the dri-devel mailing list