[PATCH] drm/stm: fix CONFIG_FB dependency

[Yannick FERTRE]

Reviewed-by: Yannick Fertré <yannick.fertre at st.com><mailto:yannick.fertre at st.com>


Arnd,
could you merge the patch?
I think that Benjamin could also merge it.

Best regards

Yannick Fertré


On 3/7/19 4:53 PM, Arnd Bergmann wrote:

The DRM_STM driver can be built independently of the framebuffer
layer, but it causes a Kconfig warning:

WARNING: unmet direct dependencies detected for FB_PROVIDE_GET_FB_UNMAPPED_AREA
  Depends on [n]: HAS_IOMEM [=y] && FB [=n]
  Selected by [y]:
  - DRM_STM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_STM32 [=n] || ARCH_MULTIPLATFORM [=y])

Selecting FB_PROVIDE_GET_FB_UNMAPPED_AREA actually has no effect
if CONFIG_FB is disabled, so we can make it a conditional 'select'
instead.

Signed-off-by: Arnd Bergmann <arnd at arndb.de><mailto:arnd at arndb.de>
---
 drivers/gpu/drm/stm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/stm/Kconfig b/drivers/gpu/drm/stm/Kconfig
index 35367ada3bc1..d15b10de1da6 100644
--- a/drivers/gpu/drm/stm/Kconfig
+++ b/drivers/gpu/drm/stm/Kconfig
@@ -6,7 +6,7 @@ config DRM_STM
        select DRM_KMS_CMA_HELPER
        select DRM_PANEL_BRIDGE
        select VIDEOMODE_HELPERS
-       select FB_PROVIDE_GET_FB_UNMAPPED_AREA
+       select FB_PROVIDE_GET_FB_UNMAPPED_AREA if FB

        help
          Enable support for the on-chip display controller on


--
Yannick Fertré | TINA: 166 7152 | Tel: +33 244027152 | Mobile: +33 620600270
Microcontrollers and Digital ICs Group | Microcontrolleurs Division
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20190308/1beb5737/attachment-0001.html>